[Kde-bindings] QVariant regression

Richard Dale rdale at foton.es
Fri Aug 7 10:33:59 UTC 2009


On Thursday 06 August 2009 11:08:49 pm David Palacio wrote:
> On Jueves 06 Agosto 2009 16:43:12 David Palacio escribió:
> > This testcase stops working after the QVariant hack removal (r1000416).
> >
> > Known affected application: Kaya.
>
> .....And the attachment
OK, I can fix that one. But we really need to review all the cases where a 
QVariant is passed to a method in the Qt and KDE apis. And that seems to 
happen a lot. 

$ rbqtapi -mQVariant | grep '.*(.*QVariant' | wc -l
170

I was a bit annoyed when I found out what had be done, because there had been 
no public discussion at the time, no entry was added to the ChangeLog and I 
didn't find out about it for a year. 

If you know what the 'munged method' scheme in the Smoke library is - ie 
creating a simplified type signature for fast lookup by adding either '#', '$' 
or '?' to the method name, you would know that a change which effectively 
always made '#' and '$' the same, was a major change. And not telling the 
maintainer about something like that is just really rude as far as I am 
concerned. I'm sorry it had to be reverted, and is causing a bit of pain by 
possibly breaking existing code.

-- Richard




More information about the Kde-bindings mailing list