[Kde-bindings] [Bug 125897] New: dcop_next handels some unsigned values wrong!

[Mathias Panzenböck]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=125897         
           Summary: dcop_next handels some unsigned values wrong!
           Product: bindings
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: kde-bindings kde org
        ReportedBy: grosser.meister.morti gmx net


Version:           435268 (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

<code>
void dcop_add (QDataStream& s, int value, QCString& type_)
{
    if (type_== "char")
        s << (Q_INT8)value;
    else if (type_ == "short")
        s << (short)value;
    else if (type_ == "int")
        s << (int)value;
    else if (type_ == "long")
        s << (long)value;
    else if (type_== "uchar" || type_ == "unsigned char")
        s << (Q_UINT8)value;
    else if (type_ == "ushort" || type_ == "unsigned short")
        s << (ushort)value;
    else if (type_ == "uint" || type_ == "unsigned int")
        s << (uint)value;
    else if (type_ == "ulong" || type_ == "unsigned long")
        s << (long)value;
}
</code>
The last line of the function is wrong. (long) should be (unsigned long).

And there is no support for "long long" (or int64_t, Q_INT64, Q_LLONG, ...) and "long double".
Well, yes, theese are non std. types, but at least (unsigned) long long and (u)int64_t are VERY common.

And in void dcop_next (QDataStream&, QCString&):
<code>
    else if (*a1 == "ulong" || *a1 == "unsigned long")
    {
        unsigned long res;
        *a0 >> res;
        return PyLong_FromLong (res);
    }
</code>
This is wrong! PyLong_FromUnsignedLong should be used!
There are also the functions PyLong_FromLongLong, PyLong_FromUnsignedLongLong, PyLong_AsUnsignedLong, PyLong_AsLongLong, PyLong_AsUnsignedLongLong etc.

(unsigned) long long support exists since python 2.2. Since I think everyone has at leat python 2.3 (everyone with kde 3), long long support should be no problem.

see:
http://docs.python.org/api/longObjects.html

see also:
File: [SVN] / trunk / KDE / kdebindings / python / pykde / sip / kdecore / bytearray.sip
Revision: 435268, Sat Jul 16 12:58:47 2005 UTC (9 months ago) by mueller

http://websvn.kde.org/trunk/KDE/kdebindings/python/pykde/sip/kdecore/bytearray.sip?rev=435268&view=markup