[Kde-bindings] [Bug 108650] memory leak in qtruby? (Qt::Socket)

[Richard Dale]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=108650         




------- Additional Comments From Richard_Dale tipitina demon co uk  2005-07-09 13:48 -------
SVN commit 433005 by rdale:

2005-07-09  Richard Dale  <Richard_Dale tipitina demon co uk>

* When a Qt method returned a QString value type, such as:
       QString QSocket::readLine()
  A temporary QString was being created that wasn't deleted and caused a 
  memory leak. Fixes problem reported by Caleb Tennis.

CCBUGS:108650


 M  +7 -0      ChangeLog  
 M  +1 -1      rubylib/qtruby/handlers.cpp  


--- trunk/KDE/kdebindings/qtruby/ChangeLog #433004:433005
 @ -1,3 +1,10  @
+2005-07-09  Richard Dale  <Richard_Dale tipitina demon co uk>
+
+	* When a Qt method returned a QString value type, such as:
+	       QString QSocket::readLine()
+	  A temporary QString was being created that wasn't deleted and caused a 
+	  memory leak. Fixes problem reported by Caleb Tennis.
+
 2005-06-28  Richard Dale  <Richard_Dale tipitina demon co uk>
 
 	* Improved display of Qt::Enums in the KDevelop debugger. With a p
--- trunk/KDE/kdebindings/qtruby/rubylib/qtruby/handlers.cpp #433004:433005
 @ -863,7 +863,7  @
 	     	} else {
                *(m->var()) = rstringFromQString(s);
 	     	}
-	     	if(m->cleanup())
+	     	if(m->cleanup() || m->type().isStack())
 	     	delete s;
          } else {
                 *(m->var()) = Qnil;