[Kde-accessibility] Review Request 125042: Fix top buttons (close button, hide numpad button)

[Fredrick Brennan]

> On Sept. 4, 2015, 12:34 p.m., Laurent Montel wrote:
> > For me seems good.
> > But we need to have review from maintainer.
> > Regards

Hello Mr. Montel...

I actually submitted these patches because I think the project is abandoned.

If the maintainer is still active, it's good, so I will wait 2 weeks before bringing it up again.

If not, I am interested in maintaining the KDE Virtual Keyboard project and bringing it into QT5.

I have a severe disability and make use of this specific software often. It will be a big inconvenience for me, and perhaps all the disabled KDE users out there who can't or won't speak up, if it becomes abandoned and does not ship in KDE5 and is dropped from repositories.

I have a good understanding of assistive technology, and have much programming experience so can learn anything about Qt I don't know.

Thank you. I added to my calendar to make sure I check this thread again in 2 weeks. If no reply from maintainer we should talk more then. :)


- Fredrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84818
-----------------------------------------------------------


On Sept. 4, 2015, 11:48 a.m., Fredrick Brennan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125042/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 11:48 a.m.)
> 
> 
> Review request for KDE Accessibility.
> 
> 
> Repository: kvkbd
> 
> 
> Description
> -------
> 
> Fix top buttons (close button, hide numpad button)
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 49ba346 
>   src/kvkbdapp.cpp 825979a 
>   src/kvkbdapp.h 498f842 
>   src/kbdtray.cpp a9cf135 
>   src/kbddock.cpp 4800022 
>   src/mainwidget.cpp 5db552e 
>   src/standart.xml 7b66c89 
>   src/themeloader.cpp f3d8e60 
>   src/vbutton.cpp 7f7cead 
> 
> Diff: https://git.reviewboard.kde.org/r/125042/diff/
> 
> 
> Testing
> -------
> 
> Hello,
> 
> The top buttons of kvkbd weren't working properly on 
> 
> * Qt: 4.8.7
> * KDE Development Platform: 4.14.11
> 
> No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
> 
> This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
> 
> 
> Thanks,
> 
> Fredrick Brennan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-accessibility/attachments/20150904/66b9aec9/attachment.html>