[Kde-accessibility] kmouth noqt3support review

[Jeremy Whiting]

The first commit is on here: https://git.reviewboard.kde.org/r/122635/
but I've done a lot on that branch since then also.

At any rate, Eli Mackenziie and Albert took close looks at it. I think
it's ready to merge, just need to decide if it's going to master or a
new frameworks branch. I'm leaning towards master, as there are bug
fixes included (like not showing the config dialog every time you
launch kmouth, even after it's been configured).

I'll fix one or two more minor things, then merge to one or the other.
If you have an opinion either way, shout now. :)

thanks,
Jeremy

On Fri, May 1, 2015 at 6:58 PM, Aleix Pol <aleixpol at kde.org> wrote:
> On Tue, Apr 28, 2015 at 3:06 AM, Jeremy Whiting <jpwhiting at kde.org> wrote:
>> Hello all,
>>
>> As the a11y team is quite small, I thought I'd reach out to the wider
>> community. KMouth has a noqt3support branch that removes the old
>> deprecated Qt3Support from it. This is the first step towards getting
>> KMouth ported to Qt5/KF5/QtSpeech. If one or many of you would check
>> it out, build it, run it, etc. and let me know of any issues found I
>> would be very grateful. That said here's a list of known issues that
>> should get fixed as the code gets refactored for Qt5/KF5/QtSpeech:
>>
>> - The initialphrasebook wizard page doesn't show how many sub items
>> are checked as items get checked like it did with K3ListView based
>> list.
>> - The PhraseBook editor dialog print functionality has been removed
>> for now. I'd like to refactor the PhraseBook class into a utility
>> class only rather than being a list of phrases with levels and such,
>> but haven't done that yet. It was simpler to remove print from
>> phrasebookdialog for now. The print functionality is still in
>> PhraseBook class, just not used in the dialog currently.
>> - I'm not sure if speaking actually works or not currently as I don't
>> have kdelibs4 based jovie installed. That will all be refactored to
>> use QtSpeech anyway (as well as the K3Process usage and such).
>>
>> Anyway, if any of you could check it builds, runs, looks decent still,
>> etc. I'll merge this to a new frameworks branch then get started
>> refactoring to Qt5/KF5/QtSpeech.
>>
>> thanks,
>> Jeremy
>>
>>>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
>
> Maybe it would be easier if we had a reviewboard to give ship it to? :)
>
> Aleix
>
>>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<