[Kde-accessibility] Review Request 126483: Use SHARE_INSTALL_PREFIX to install appstream data

Rex Dieter rdieter at gmail.com
Wed Dec 23 14:52:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126483/#review89997
-----------------------------------------------------------

Ship it!


+1, that's the convention most other kde modules use.

- Rex Dieter


On Dec. 23, 2015, 11:35 a.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126483/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 11:35 a.m.)
> 
> 
> Review request for KDE Accessibility and Jeremy Whiting.
> 
> 
> Repository: jovie
> 
> 
> Description
> -------
> 
> ...instead of hard-coding share/.. which is not helpful on a multiarch
> layout, where the prefix might be something like /usr/${arch} but arch
> independent files should still go into /usr/share.
> 
> 
> Diffs
> -----
> 
>   jovie/CMakeLists.txt 66b25f7 
> 
> Diff: https://git.reviewboard.kde.org/r/126483/diff/
> 
> 
> Testing
> -------
> 
> jovie.appdata.xml gets installed into the desired location.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-accessibility/attachments/20151223/e554c0d3/attachment.html>


More information about the kde-accessibility mailing list