[Kde-accessibility] Review Request: Make the new welcome-page a bit prettier
Peter Grasch
grasch at simon-listens.org
Sat May 5 22:15:05 UTC 2012
> On May 5, 2012, 7:39 p.m., Peter Grasch wrote:
> > Hi Anton, this is awesome! Thanks for taking the time!
> >
> > First I thought that using KIconLoader::iconPath() to use the users own icon would be even better in my mind but I couldn't find a way to replicate the nice off-center / half transparency effect with CSS. So unless you know / find something I'm missing, let's keep the custom pixmaps.
> >
> > Other than that, the implementation looks fine to me. Only request: Could you maybe use view-pim-news for the acoustic model section? It's what we usually use as an icon for speech models. Thanks.
>
> Anton Kreuzkamp wrote:
> Manipulating the images via css to be able to use any pixmap as background-image would be technically possible by putting an empty widget with the background-image below the groupbox and give it an opacity of 0.5, but thats imo a huge overload compared to the benefit (besides I've never tested it and thus don't know whether it would really work). So I think the custom pixmaps are the best solution.
Agreed on all points. Ship it!
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104868/#review13485
-----------------------------------------------------------
On May 5, 2012, 9:35 p.m., Anton Kreuzkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104868/
> -----------------------------------------------------------
>
> (Updated May 5, 2012, 9:35 p.m.)
>
>
> Review request for KDE Accessibility and Peter Grasch.
>
>
> Description
> -------
>
> Instead of commenting on Peter's blog with a mockup that would be equally difficult to do like this, I decided to answer with a patch :)
> This patch doesn't change anything in the functionality or the interface itself, but it puts icons for each of the 4 categories on the welcome-screen in the background of each (equal to what amarok does and kdevelop will do in it's new welcome-screen).
> This helps a bit to seperate the categories better, but more importantly it simply (partially) fetches back the wow-factor the old welcome screen had.
> I'm not quite sure, whether these are the best icons for the categories, I'm open to better suggestions.
>
>
> Diffs
> -----
>
> simon/icons/CMakeLists.txt 106884f
> simon/icons/bg-acoustic-model.png PRE-CREATION
> simon/icons/bg-recognition.png PRE-CREATION
> simon/icons/bg-scenarios.png PRE-CREATION
> simon/icons/bg-training.png PRE-CREATION
> simon/src/welcomepage.cpp c761709
>
> Diff: http://git.reviewboard.kde.org/r/104868/diff/
>
>
> Testing
> -------
>
> Tested with different widget- and color-themes and I think it looks pretty nice with all of them.
>
>
> Screenshots
> -----------
>
> Simon Welcomepage with icons in the background (updated)
> http://git.reviewboard.kde.org/r/104868/s/560/
>
>
> Thanks,
>
> Anton Kreuzkamp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-accessibility/attachments/20120505/f204a792/attachment.html>
More information about the kde-accessibility
mailing list