[Kde-accessibility] Patch for accessibility bug

[Olaf Jan Schmidt]

--------------Boundary-00=_7QPFHUOBHBVLXANLQQGC
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello!

Does anyone no the current maintainer of kcontrol > access > kaccess.cpp?

I would be very grateful if someone with more knowledge of KDE internals=20
could have a look at the attached diff and check whether this really=20
fixes bug 41778 as intended. The bug really needs to be fixed in 3.1, as=20
it makes some of the accessibility functions more or less unusable.
See http://bugs.kde.org/show_bug.cgi?id=3D41778.

I do not have a CVS account, so if someone commits this for me, the bug=20
will be gone in KDE 3.1, otherwise it will stay.

Technical details of the patch: XKB has a function to automatically switc=
h=20
of accessibility functions after a period of inactivity.

kaccess.cpp forgets to disable this timeout function. The bug fix adds a=20
line which switches the timeout off.

As there is no option in kcontrol to set the timeout, it should always be=
=20
disabled. Maybe it is possible to add an option in KDE 3.2 about whether=20
the timeout should be enabled, but  we are in string freeze and need a=20
soulution for KDE 3.1.

See also the discussion on kde-accessibility=20
(http://lists.kde.org/?l=3Dkde-accessibility&m=3D103525621028139&w=3D2). =
Thanks=20
to Bill Haneman from the Gnome Accessibility team who watched=20
kde-accessibility and pointed us to the cause of the problem.

A lot of physically handicapped people need this problem fixed, so I woul=
d=20
really appreciate it if someone with more knowledge than me could make=20
sure this makes it into KDE 3.1

This is the first time I have tried to write a bug fix for KDE, so please=
=20
don't be angry if the bug fix contains errors. (I have not even learned=20
C++ properly yet.)

Olaf.

PS: Please CC to me, as I am not in kde-devel.

- --=20
Meine Internetseiten:
http://www.GebetGenerator.de, http://www.amen-online.de

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAj22mAQACgkQoLYC8AehV8cLTgCgzQe/CJhgiV9iejdQtNXvftpS
R90An3Vn305o1Rn1fvm2F89d9cy9e8Mf
=3D0yKH
-----END PGP SIGNATURE-----

--------------Boundary-00=_7QPFHUOBHBVLXANLQQGC
Content-Type: text/x-diff;
  charset="us-ascii";
  name="kaccess.cpp.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="kaccess.cpp.diff"

107,108c107,108
<   
<   // turn of two-keys-disable sticky keys option
---
> 
>   // turn off two-keys-disable sticky keys option
109a110,112
> 
>   // turn off timeout
>   xkb->ctrls->enabled_ctrls &= ~XkbAccessXTimeoutMask;

--------------Boundary-00=_7QPFHUOBHBVLXANLQQGC--