[Kalzium] [Bug 122760] Decimal comma instead of point in German Kalzium

Pino Toscano toscano.pino at tiscali.it
Wed Mar 21 19:11:37 CET 2007


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=122760         




------- Additional Comments From toscano.pino tiscali it  2007-03-21 19:11 -------
The patch may work, but it needs some massage here and there:

> 			v = QString::number( value );
>+			v = KalziumUtils::localizedValue( v, 6 );
What's this nonsense?

>+		static QString localizedValue( const QString& string, int precision, unsigned long options = 0 );
Why the format from string? We use numbers everywhere, and strings just when displaying, so this function and the other one that takes the QString as parameter are completely useless, IMHO.

+QString KalziumUtils::localizedValue( int val )
+{
+	return KGlobal::locale()->formatLong( val );	
+}
What's this function for? Just merge it into the other one, and for example use a flag to determine whether use KLocale::formatNumer() or KLocale::formatLong().


More information about the Kalzium mailing list