[k3b] [Bug 384471] New: Media type selection for Image burning is partly wrong, comments are very wrong

[Thomas Schmitt]

https://bugs.kde.org/show_bug.cgi?id=384471

            Bug ID: 384471
           Summary: Media type selection for Image burning is partly
                    wrong, comments are very wrong
           Product: k3b
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: k3b at kde.org
          Reporter: scdbackup at gmx.net
                CC: michalm at jabster.pl, trueg at kde.org
  Target Milestone: ---

Hi,

K3b::Iso9660ImageWritingJob::startWriting() inapropriately accepts DVD+R for
m_writingMode == K3b::WritingModeRestrictedOverwrite :

 
https://cgit.kde.org/k3b.git/tree/libk3b/jobs/k3biso9660imagewritingjob.cpp#n261
    else if( m_writingMode == K3b::WritingModeRestrictedOverwrite ) {
        mt =
K3b::Device::MEDIA_DVD_PLUS_R|K3b::Device::MEDIA_DVD_PLUS_R_DL|K3b::Device::MEDIA_DVD_PLUS_RW|K3b::Device::MEDIA_DVD_RW_OVWR;

Restricted Overwrite a speciality of formatted DVD-RW.
"Overwrite" like with DVD-RAM, DVD+RW, BD-RE. "Resctricted" because only
full chunks of 32 KiB may be written.

The allowed gestures are also allowed with DVD+RW, DVD-RAM, BD-RE.
But it is not compatible with DVD+R or DVD+R DL.

So, after due checking whether WritingModeRestrictedOverwrite really
means what its name suggests, all types except formatted DVD-RW should be
removed from the "mt" list.
If one wants to allow DVD+RW, then also DVD-RAM and BD-RE should be allowed.

(In general i wonder why K3B already knows the future write type but not the
 medium type yet. Must be a GUI precognition thing.)

--------------------------------------------------------------------------

The comment in line 236 ff. is obviously outdated. The choice of wanted DVD
(and now BD) does not depend on the use of growisofs. The comment lists 10
decisions or remarks:

1. Ok. (but obviously writing app is not auto)
2. Wrong. The code looks for cdrdao as writing app, not for "not growisofs".
3. Wrong. If not cdrdao and not d->isDvdImage, then all media (including BD)
4. Ok.
5. No such code is to see.
6. No such code is to see.
7. No such code is to see.
8. No such code is to see.
9. Wrong. DVD+R and DVD+R DL are accepted inappropiately.
          DVD+RW is ok, but misplaced here, nevertheless.
10. obsolete, now that Bug 381074 is fixed.

In the code i see currently these five decisions:

1. If special CD features are requested: CD types only
   Special are: K3b::WritingAppCdrdao , K3b::WritingModeTao , WritingModeRaw
2. If formatted DVD-RW is requested: formatted DVD-RW, DVD+R, DVD+R DL, DVD+RW
   Request is: K3b::WritingModeRestrictedOverwrite
3. If image is larger than 900 MiB (d->isDvdImage == true): DVD or BD types
   See K3b::Iso9660ImageWritingJob::start()
4. If image not larger than 900 MiB: All media types
5. If not decided yet: All media types

After fixing my objection above, number 2 should become

2. If formatted DVD-RW is requested: formatted DVD-RW only
   Request is: K3b::WritingModeRestrictedOverwrite

Have a nice day :)

Thomas

-- 
You are receiving this mail because:
You are the assignee for the bug.