[k3b] [Bug 381074] [MATSHITA BD-MLT UJ240AS] Does not write image "debian-8.8.0-amd64-BD-1.iso"

[Thomas Schmitt]

https://bugs.kde.org/show_bug.cgi?id=381074

--- Comment #70 from Thomas Schmitt <scdbackup at gmx.net> ---
Hi,

Ja ! I knew it when i saw it ... now in hindsight ... :))

I had gnawed on the code for the wrong task "Data" rather than "Image".
This little shell beauty in my K3B git clone finally gave me the nudge.
It looks for MEDIA_WRITABLE_DVD at the end of a C/C++ statment:

  $ fgrep -r MEDIA_WRITABLE_DVD';' .
  ./libk3b/projects/videodvd/k3bvideodvddoc.cpp:    return
K3b::Device::MEDIA_WRITABLE_DVD;
  ./libk3b/jobs/k3biso9660imagewritingjob.cpp:            mt =
K3b::Device::MEDIA_WRITABLE_DVD;
  ./libk3b/jobs/k3biso9660imagewritingjob.cpp:        mt =
K3b::Device::MEDIA_WRITABLE_DVD;


> I am happy :-) We have solved this "Error".

This error really does not need to be put in quotes. Be proud of it.

You are the first who tried burning a BD sized image file since K3B learned
to handle BD. That's a fat bug catch.
Congrats for being the user who had the endurance to complete this thread.

------------------------------------------------------------------
@Leslie:

Now the qDebug() statements about "Bug 381704" need to be removed.

I pondered in advance about the general appropriateness of the two lines

  mt = K3b::Device::MEDIA_WRITABLE_DVD | K3b::Device::MEDIA_WRITABLE_BD;

They are good. DVD and BD are not really different when it comes to MMC specs
and to backend programs which handle both media families. The true divide
is between pre-DVD (i.e. CD ) and post-DVD (i.e. DVD and BD).

So these two changed lines are the final fix for this bug.
Fix commit title could be something like
  "The task of burning an image file to media was not yet prepared
   to accept BD media."
Maybe there is a more official K3B term for "task of burning an image file
to media".

Congrats to you, too. I hope your health is getting better.

--------------------

Nevertheless ... the now 10 comment items in startWriting() of
libk3b/jobs/k3biso9660imagewritingjob.cpp are completely out of sync with
the current code underneath them.
This needs mending.
Shall i open a new bug for this ?

Further about this fgrep match:
    ./libk3b/projects/videodvd/k3bvideodvddoc.cpp:    return
K3b::Device::MEDIA_WRITABLE_DVD;
Does K3B burn Blu-ray video ? Is there need for inspection ?

Have a nice day :)

Thomas

-- 
You are receiving this mail because:
You are the assignee for the bug.