[k3b] [Bug 386105] K3b FFmpeg decode plugin seems to be broken, produces noise

[Leslie Zhai]

https://bugs.kde.org/show_bug.cgi?id=386105

Leslie Zhai <lesliezhai at llvm.org.cn> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lesliezhai at llvm.org.cn

--- Comment #4 from Leslie Zhai <lesliezhai at llvm.org.cn> ---
Hi blaze,

Thanks for your report!

> Also ffmpeg plugin currently uses deprecated API

I migrated libAV before
https://github.com/isoft-linux/libKeyFrame/blob/master/libKeyFrame.c#L295  and
welcome the patch about migration :)

> https://i.imgur.com/l9wpxYG.png

That is very good DIFF! it is clear that K3B ffmpeg plugin bring in the noise.
but it is not easy to use FFT and Band-pass filter to filter it ...

> What this code actually does? It looks the most suspicious. And what "if needed" does mean?

I have no idea why need to SWAP, perhaps it is better to ask the original
author :)
https://github.com/KDE/k3b/commit/97f72a28ef87ef62f89967e237f441e03d3b5b3b#diff-edc47aa8fac740c80253cd4bec4ba15dR207


You can test to comment the SWAP code, then rebuild K3B to verify whether or
not produce the noise.

Regards,
Leslie Zhai

-- 
You are receiving this mail because:
You are the assignee for the bug.