[k3b] [Bug 379268] Importing previous session does nothing (version 17.04.0)

Leslie Zhai bugzilla_noreply at kde.org
Tue May 2 04:39:17 UTC 2017


https://bugs.kde.org/show_bug.cgi?id=379268

--- Comment #41 from Leslie Zhai <lesliezhai at kde-china.org> ---
Git commit a8f1221b407b7861771c8d8b1c422bb43d1585ce by Leslie Zhai.
Committed on 02/05/2017 at 04:27.
Pushed by lesliezhai into branch 'master'.

Fix DataMultisessionImportDialog No okClicked or cancelClicked signal issue.

K3b was developed by Sebastian Trueg started in 1998!
and K3b::DataMultisessionImportDialog was migrated by Michał Małek to KF5 in
2014!

There are okClicked and cancelClicked signals for KDialog.
Unfornately KDialog has been deprecated and moved to kde4support.
KF5 Prefer QDialog, but there is no such signal, and clang analyzer was not
taught
to find such migration issue :)

Please (code review) pay more attention to
K3b::DataMultisessionImportDialog::slotOk
and K3b::DataDoc::importSession, I prefer to use the backends provided by
libburnia
developing and maintaining by Thomas if others failed to importSession!

M  +3    -3    src/projects/k3bdatamultisessionimportdialog.cpp

https://commits.kde.org/k3b/a8f1221b407b7861771c8d8b1c422bb43d1585ce

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the k3b mailing list