Review Request 130034: Make Qt5WebKitWidgets optional

Andreas Sturmlechner andreas.sturmlechner at gmail.com
Mon Mar 20 07:08:19 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130034/
-----------------------------------------------------------

(Updated March 20, 2017, 7:08 a.m.)


Status
------

This change has been marked as submitted.


Review request for K3b and Leslie Zhai.


Changes
-------

Submitted with commit 28df847f360e881711b40bcd50ee0a266c55d2fa by Andreas Sturmlechner to branch Applications/17.04.


Repository: k3b


Description
-------

It really is of very limited use here. The patch goes back to something
Red Hat had been applying to k3b since at least 2012, but actually makes
Qt5WebKitWidgets conditional instead of removing it completely.


Diffs
-----

  CMakeLists.txt 808bd0b9a06d9cc5cc78555ef595f9a1165776e5 
  src/CMakeLists.txt 8ec0fbdf0a4ca1b9828eee6720e862e6dc565dad 
  src/k3bdiskinfoview.h 0b27e630d07ed70cb6c4433e6f6fe4af985d9c94 
  src/k3bdiskinfoview.cpp 1005ef8477da9ac863cf17e257f9ad228479daab 

Diff: https://git.reviewboard.kde.org/r/130034/diff/


Testing
-------


Thanks,

Andreas Sturmlechner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20170320/c01dc0f2/attachment.html>


More information about the k3b mailing list