[k3b] [Bug 375016] k3b 17.04: cannot add files to data project

Kai Uwe Broulik bugzilla_noreply at kde.org
Sat Feb 11 16:05:01 UTC 2017


https://bugs.kde.org/show_bug.cgi?id=375016

Kai Uwe Broulik <kde at privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/k3b
                   |                            |/d21096fa6e10fe03e524a1b0be
                   |                            |eb0b16a0c22681
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #5 from Kai Uwe Broulik <kde at privat.broulik.de> ---
Git commit d21096fa6e10fe03e524a1b0beeb0b16a0c22681 by Kai Uwe Broulik.
Committed on 11/02/2017 at 16:03.
Pushed by broulik into branch 'master'.

Fix adding files to data project

In cf01ff3159dbddb97e0e67246dee16441a64984a this broke by randomly using
QSharedPointer in the wrong way.
There was only this one item being referenced, once it fell out of scope it got
deleted, and then by the
time the event loop returned and the queued invocation was processed, the
object was already gone.

Just use WA_DeleteOnClose which will clean up nicely once we're done.

Differential Revision: https://phabricator.kde.org/D4571

M  +9    -7    src/projects/k3bdataurladdingdialog.cpp

https://commits.kde.org/k3b/d21096fa6e10fe03e524a1b0beeb0b16a0c22681

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the k3b mailing list