[k3b] [Bug 387765] K3b says that blu-ray ISO is not recognizable

[Thomas Schmitt]

https://bugs.kde.org/show_bug.cgi?id=387765

Thomas Schmitt <scdbackup at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |scdbackup at gmx.net

--- Comment #5 from Thomas Schmitt <scdbackup at gmx.net> ---
Hi,

this is not really the field where i am expert. C++ dyslexia and such ... 

K3B issues the warning message if it encounters an image which it
classifies as IMAGE_UNKNOWN.
In the course of bug 344392, the changesets
 
https://cgit.kde.org/k3b.git/commit/?id=54173816164c825f077e8288b628e550b51ddccb
 
https://cgit.kde.org/k3b.git/commit/?id=585067b15d1d3b0d875e092c775f1925e2ba270f
 
https://cgit.kde.org/k3b.git/commit/?id=3d21bdca2a9ec4ef2d6226991118ba0e3f09a45a
introduced a new classification IMAGE_RAW which is set when the
warning appears and the user confirms that burning shall go on.

In my git clone of K3B and on
  https://cgit.kde.org/k3b.git/tree/src/misc/k3bimagewritingdialog.cpp#n873
i see:

        if (d->foundImageType == IMAGE_UNKNOWN) {
            if (KMessageBox::questionYesNo(this,
                                           i18n("Type of image file is not
recognizable. Do you want to burn it anyway?"),
                                           i18n("Unknown image type")) ==
KMessageBox::Yes) {
                d->foundImageType = IMAGE_RAW;
                d->imageFile = path;
            }
        }

The decisive line is the one that mentions IMAGE_RAW.
Do you have it in your local K3B source ?

The consequence of this setting should be in 
  https://cgit.kde.org/k3b.git/tree/src/misc/k3bimagewritingdialog.cpp#n707
as
    case IMAGE_RAW:
    case IMAGE_ISO:
    {
        ...
        K3b::Iso9660ImageWritingJob* job_ = new K3b::Iso9660ImageWritingJob(
&dlg );

Do you see this double "case" statement in your local source ?

-------------------------------------------------------------------------

If the local code is up to date, then we need more information.

- How does the program react after you confirm that the image shall be
  burned indeed ? Any further messages ?

- Does
                d->foundImageType = IMAGE_RAW;
  get executed after the warning dialog ?
  (A debug message would bring clarity.)

- Does program execution get to
    https://cgit.kde.org/k3b.git/tree/src/misc/k3bimagewritingdialog.cpp#n658
  If so, what is the value of
    d->currentImageType() 
  ?
  (A debug message before
      switch( d->currentImageType() ) {
   could bring clarity.)

-------------------------------------------------------------------------

Have a nice day :)

Thomas

-- 
You are receiving this mail because:
You are the assignee for the bug.