[k3b] [Bug 383835] Crash after closing audio project

[Leslie Zhai]

https://bugs.kde.org/show_bug.cgi?id=383835

--- Comment #12 from Leslie Zhai <lesliezhai at llvm.org.cn> ---
> //m_plugin(plugin)

yes, ProjectPlugin* m_plugin   is Dead assignment
http://www.leetcode.cn/2016/11/analyzing-code-for-kde-qt-open-source-components.html#k3b
 it never be used after assginment during constructor.


diff --git a/src/projects/k3bprojectplugindialog.cpp
b/src/projects/k3bprojectplugindialog.cpp
index 994424f..84841f6 100644
--- a/src/projects/k3bprojectplugindialog.cpp
+++ b/src/projects/k3bprojectplugindialog.cpp
@@ -25,8 +25,7 @@ K3b::ProjectPluginDialog::ProjectPluginDialog(
K3b::ProjectPlugin* plugin, K3b::
                             QString(),
                             START_BUTTON|CANCEL_BUTTON,
                             START_BUTTON,
-                            plugin->metaObject()->className() ),
-      m_plugin(plugin)
+                            plugin->metaObject()->className() )
 {
     m_pluginGui = plugin->createGUI( doc, this );
     Q_ASSERT( m_pluginGui );
diff --git a/src/projects/k3bprojectplugindialog.h
b/src/projects/k3bprojectplugindialog.h
index 8a085c5..a799703 100644
--- a/src/projects/k3bprojectplugindialog.h
+++ b/src/projects/k3bprojectplugindialog.h
@@ -36,7 +36,6 @@ namespace K3b {
         void loadSettings( const KConfigGroup& config );

     private:
-        ProjectPlugin* m_plugin;
         ProjectPluginGUIBase* m_pluginGui;
     };
 }


but I argue that it might not the root cause...

-- 
You are receiving this mail because:
You are the assignee for the bug.