[k3b] [Bug 382941] Segfault from getSupportedWriteSpeedsVia2A

[Leslie Zhai]

https://bugs.kde.org/show_bug.cgi?id=382941

--- Comment #5 from Leslie Zhai <lesliezhai at llvm.org.cn> ---
(In reply to Mark from comment #4)
> Unfortunately the fix causes a new problem. All is fine until opening the
> burn dialog which then says "Please insert an empty disc..."  Medium Info
> shows no supported writing speeds.
> 
> Reverting k3bdeviceglobals.cpp 217 to:
>     if (d==NULL) {
> 
> plus my original hack has it working again.

only check whether or not `d` is NULL pointer is not enough! there is
out-of-bounds hidden danger when strlen(d) is 1, then d[1] will out-of-bounds.


> 
> I can spend some time this weekend looking at it in more detail so any clues
> you could give me as to what to look for would help.

-- 
You are receiving this mail because:
You are the assignee for the bug.