[k3b] [Bug 344392] Can't burn BD50 ISO image - Seems not to be a usable image

[Thomas Schmitt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=344392

--- Comment #14 from Thomas Schmitt <scdbackup at gmx.net> ---
Hi,

Leslie Zhai:
> I am reading carefully about your implementation about IMAGE_RAW. and please
> rebase your patch for image-raw branch

Well, i did not implement anything but only inspected the situation
and made a rough plan what would need a change.
I am running neither KDE nor Gnome on my workstation. Building K3B
from source would start a big endeavor on its own.

But i will from now on study that branch (maybe still using Debian
code search, because searching "IMAGE_ISO" in https://quickgit.kde.org/
yields no match).

Let's see whether i find something to nitpick:
-------------------------------------------------------------------------
Line 473 of k3bimagewritingdialog.cpp:

    d->comboImageType->addItem(i18n("Optical disc media"));

I would rather call it "ISO 9660 filesystem image".

I is not an optical medium but rather shall get onto optical medium.
Albeit ISO 9660 (and its predecessor High Sierra) was announced as
the filesystem for CD-ROM media, ISO 9660 has long escaped that cage.
It is as read-only filesystem very well suited for backup and archiving.
In its role as bootable filesystem it has conquered USB sticks and
memory cards.

-------------------------------------------------------------------------
Line 707:

    case IMAGE_RAW:
    case IMAGE_ISO:
    {
        K3b::Iso9660 isoFs( d->imageFile );
        if( isoFs.open() ) {
            ....
        }

I proposed to introduce IMAGE_RAW in order to be able to skip this test
for size. So there should be an if around it:

    case IMAGE_RAW:
    case IMAGE_ISO:
    {
        if ( d->currentImageType() == IMAGE_ISO ) {
            K3b::Iso9660 isoFs( d->imageFile );
            if( isoFs.open() ) {
                ....
            }
        }

Has it been tested already that

    K3b::Iso9660ImageWritingJob* job_ = new K3b::Iso9660ImageWritingJob( &dlg
);

works with non ISO 9660 images ?

-------------------------------------------------------------------------
Line 871:

        if (KMessageBox::questionYesNo(this,
                                       i18n("Seems not to be a usable image, do
you want to treat it as RAW?"),
                                       i18n("Unkown image type")) ==
KMessageBox::Yes) {

The text is somewhat misleading, especially since "raw" has an old
meaning in the context of CD burning.

I would rather state
  "Type of image file is not recognizable. Do you want to burn it anyway ?"

-------------------------------------------------------------------------
Line 938:

You removed the case  d->currentImageType() == IMAGE_UNKNOWN .

I am not sure whether IMAGE_UNKNOWN can reach this code. Nevertheless
we would need a source code review to assert that it cannot.

So i'd cowardly keep IMAGE_UNKNOWN in the "||" list.

-------------------------------------------------------------------------

Have a nice day :)

Thomas

-- 
You are receiving this mail because:
You are the assignee for the bug.