[k3b] [Bug 372094] Please restore wodim support

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=372094

--- Comment #1 from Kevin Kofler <kevin.kofler at chello.at> ---
I will also note that your changes have several logic errors:

-    : K3b::AbstractCdrtoolsProgram( QLatin1String( "cdrecord" ),
QLatin1String( "wodim" ) )
+    : K3b::AbstractCdrtoolsProgram( QLatin1String( "cdrecord" ),
QLatin1String("cdrecord") )

(2 times the same command, probably not what you want)

-        // but prefer growisofs to wodim for DVDs
+        // but prefer growisofs for DVDs
         if ( d->usedWritingApp == K3b::WritingAppAuto ) {
-            if
(k3bcore->externalBinManager()->binObject("cdrecord")->hasFeature( "wodim" ))
-                d->usedWritingApp = K3b::WritingAppGrowisofs;
-            else
-                d->usedWritingApp = K3b::WritingAppCdrecord;
+            d->usedWritingApp = K3b::WritingAppCdrecord;

(The comment says "prefer growisofs", the code says "prefer cdrecord".)

but instead of fixing those errors, please revert this commit wholesale, or K3b
will have to be removed from Fedora.

-- 
You are receiving this mail because:
You are the assignee for the bug.