[k3b] Review Request 126646: Don't segfault when failing to load a plugin.

[Johannes Obermayr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126646/#review90947
-----------------------------------------------------------


Fixed it another way (.desktop doesn't work): https://quickgit.kde.org/?p=k3b.git&a=commit&h=df9384

- Johannes Obermayr


On Jan. 5, 2016, 9:39 nachm., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126646/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 9:39 nachm.)
> 
> 
> Review request for K3b and Johannes Obermayr.
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> With today's build of kf5 branch k3b wouldn't start because the KPluginInfo for one of the plugins (I think the maddecoder most likely) fails to load and causes a segfault when trying to access the pluginName().
> 
> 
> Diffs
> -----
> 
>   src/k3bsystemproblemdialog.cpp 4e3022a 
> 
> Diff: https://git.reviewboard.kde.org/r/126646/diff/
> 
> 
> Testing
> -------
> 
> I added a qDebug() for valid plugins to see which name k3bmaddecoder is getting also, and fixed the name check in this patch. It's still failing to load though with debug output like this:
> 
> "K3b MAD Decoder" "k3bmaddecoder"
> Loaded plugin "K3b MAD Decoder"
> "k3bmaddecoder.desktop" has no desktop group, cannot construct a KPluginInfo object from it.
> 
> similar output for other plugins. It does seem to start and lets me add mp3 files to an audio cd project though with this change.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20160112/84f10a51/attachment.html>