[k3b] Review Request 127566: Rename appdata file to match desktop file

Matthias Klumpp matthias at tenstral.net
Sun Apr 3 20:48:17 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127566/#review94219
-----------------------------------------------------------




src/k3b.appdata.xml 
<https://git.reviewboard.kde.org/r/127566/#comment64099>

    You shouldn't delete the <id/> tag (this makes the metadata completely invalid), but rather fix it to match the .desktop filename.
    Renaming the metainfo file itself isn't even required, but it's the better thing to do ;-)
    
    The right <id/> tag in this case would be:
    <id>org.kde.k3b.desktop</id>


- Matthias Klumpp


On April 3, 2016, 8:12 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127566/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 8:12 p.m.)
> 
> 
> Review request for K3b and Matthias Klumpp.
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> This silences appstream validation warnings like on: 
> https://build.kde.org/job/k3b%20kf5%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastBuild/console
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt dfe20df4b9087264b87afb2b9430d4387e85b061 
>   src/k3b.appdata.xml b562689d35fb5af8e2b3b3d673834af8dbf25733 
> 
> Diff: https://git.reviewboard.kde.org/r/127566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20160403/17b917d9/attachment.html>


More information about the k3b mailing list