[k3b] Review Request 125804: revert "fix" which adds literal quote chars to the filename

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125804/
-----------------------------------------------------------

(Updated Oct. 26, 2015, 9:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for K3b.


Changes
-------

Submitted with commit 9f109bbc7fe718135da402535f6ca7ca5c105d4d by Martin Koller to branch master.


Bugs: 350403
    http://bugs.kde.org/show_bug.cgi?id=350403


Repository: k3b


Description
-------

commit 2786d19f added explicit quote characters around the filename, which is wrong since the filename is passed into a QStringList,
which passes all its separate arguments to the started process. Adding quote chars would lead to the filename having the quote chars as part of the filename.
The commit above tried to fix bug 326097 but since this bug does not explain what the problem was, I'm sure the reporter had some other problem.
The mentioned commit is definitely wrong.


Diffs
-----

  libk3b/jobs/k3bvideodvdtitletranscodingjob.cpp 95e4811 

Diff: https://git.reviewboard.kde.org/r/125804/diff/


Testing
-------

ripped a DVD with a filename which contains blanks. Without that fix, you get an error (as seen in the bug report).
With the fix, it works.


Thanks,

Martin Koller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20151026/26899e0f/attachment.html>