[k3b] Review Request 126135: Use FindPkgConfig instead of UsePkgConfig

Heiko Becker heirecka at exherbo.org
Sat Dec 12 11:37:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126135/
-----------------------------------------------------------

(Updated Dec. 12, 2015, 11:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for K3b.


Changes
-------

Submitted with commit 399adb1ace87ab25525922f422e5cad3b30f5b60 by Heiko Becker to branch 2.0.


Repository: k3b


Description
-------

UsePkgConfig is marked as obsolete and doesn't handle differently
named pkg-config executables, like architecture or toolchain prefixed
ones, well. The FindPkgConfig module respects the PKG_CONFIG env
variable and sets PKG_CONFIG_EXECUTABLE accordingly.


Diffs
-----

  cmake/modules/FindSndfile.cmake c5d21b5 

Diff: https://git.reviewboard.kde.org/r/126135/diff/


Testing
-------

libsndfile was found with the help of x86_64-pc-linux-gnu-pkg-config, k3b built successfully with it.


Thanks,

Heiko Becker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20151212/db988ea2/attachment.html>


More information about the k3b mailing list