[k3b] Review Request 125000: use standard icons

[Albert Astals Cid]

> On ago. 31, 2015, 12:57 p.m., Jeremy Whiting wrote:
> > Looks good to me. But which bug are you referring to?
> 
> andreas kainz wrote:
>     https://bugs.kde.org/show_bug.cgi?id=352054
> 
> andreas kainz wrote:
>     done https://quickgit.kde.org/?p=k3b.git&a=commit&h=7bbd9edd1a2f9b7f738fccc2d9d57c5d15b2bc67
>     
>     don't know how to link git with reviewboard thought with the number in the comment. but I don't see it here.

See https://techbase.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

Please also close the bug manually.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125000/#review84640
-----------------------------------------------------------


On ago. 31, 2015, 1:07 p.m., andreas kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125000/
> -----------------------------------------------------------
> 
> (Updated ago. 31, 2015, 1:07 p.m.)
> 
> 
> Review request for K3b and Sebastian Kügler.
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> most of the k3b icons are standard icons only the two are not available and I think also not necessary.
> 
> please use the icons from /usr/share/icons/.... instead of some hardcoded icons. see bug
> 
> 
> Diffs
> -----
> 
>   src/k3b.cpp a7ccc57 
> 
> Diff: https://git.reviewboard.kde.org/r/125000/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20150831/e0461561/attachment-0001.html>