[k3b] Review Request 120402: Don't preview if called process failed

Michal Malek michalm at jabster.pl
Sun Sep 28 08:53:58 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120402/#review67546
-----------------------------------------------------------



src/rip/videodvd/k3bvideodvdrippingpreview.cpp
<https://git.reviewboard.kde.org/r/120402/#comment47085>

    I suggest using more readable form:
    if( exitStatus != QProcess::NormalExit )


- Michal Malek


On Wrz 28, 2014, 8:16 rano, Johannes Obermayr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120402/
> -----------------------------------------------------------
> 
> (Updated Wrz 28, 2014, 8:16 rano)
> 
> 
> Review request for K3b.
> 
> 
> Bugs: 268680
>     http://bugs.kde.org/show_bug.cgi?id=268680
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> None
> 
> 
> Diffs
> -----
> 
>   src/rip/videodvd/k3bvideodvdrippingpreview.cpp 0c36c97 
> 
> Diff: https://git.reviewboard.kde.org/r/120402/diff/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Johannes Obermayr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20140928/c1834e06/attachment.html>


More information about the k3b mailing list