[k3b] [Bug 340515] k3b crashes when building dvd-rw from iso file

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=340515

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |2.0.3
      Latest Commit|                            |http://commits.kde.org/k3b/
                   |                            |839f731e5940705afa1b9ea8c8d
                   |                            |bb4678e7d4de9
             Status|CONFIRMED                   |RESOLVED

--- Comment #4 from Albert Astals Cid <aacid at kde.org> ---
Git commit 839f731e5940705afa1b9ea8c8dbb4678e7d4de9 by Albert Astals Cid.
Committed on 03/11/2014 at 21:09.
Pushed by aacid into branch '2.0'.

Don't increase iterator after it's already at the end

Don't increase it after it's already at the end. We are increasing the iterator
inside of the loop, and as part of the for so it'll be past the end and the it
!= l.constEnd() will be true and we will crash.

Changed the code so that it only increases the iterator if we know it's not at
the end already.

Did some stand-alone code that runs over

const char * processResult =
"p1445\ncchrome\nf5\nf6\nf12\nf13\nf16\nf17\nf21\nf22\nf26\nf27\nf32\nf33\np1453\ncchrome\nf6\nf7\np1528\ncdbus-launch\nf8\np1530\ncenlightenment\nf5\nf6\nf10\nf11\nf34\nf37\nf38\np1533\ncefreetd\nf6\nf7\np1540\ncgvfsd\nf6\nf7\np1565\ncterminology\nf5\nf6\nf10\nf11\np1566\ncfirefox\nf10\nf11\nf12\nf13\nf14\nf15\nf22\nf23\nf161\nf162\np1619\ncenlightenment_f\nf5\nf6\np1631\nctempget\nf1\nf5\nf6\nf37\nf38\np1679\ncat-spi-bus-laun\nf5\nf6\np1736\ncplugin-containe\nf6\nf7\nf11\nf12\np1822\ncthunderbird\nf10\nf11\nf12\nf13\nf14\nf15\nf21\nf22\nf44\nf176\np2261\nckdeinit4\nf0\nf3\nf5\np2263\ncklauncher\nf0\nf3\nf4\nf5\nf6\nf10\nf11\np2265\nckded4\nf0\nf4\nf6\np2267\ncgam_server\nf6\nf7\np2346\nckuiserver\nf0\nf4\nf6\np2381\ncknotify4\nf0\nf4\nf6\np2633\nck3b\nf5\nf6\nf14\nf21\nf22\nf25\nf26\nf28\nf33\nf34\np2791\nclsof\nf0\nf1\nf2\nf4\nf5\np2792\nclsof\nf3\nf6\n";

And it crashed, now doesn't crash anymore
REVIEW: 120944
FIXED-IN: 2.0.3

M  +4    -1    src/k3blsofwrapper.cpp

http://commits.kde.org/k3b/839f731e5940705afa1b9ea8c8dbb4678e7d4de9

-- 
You are receiving this mail because:
You are the assignee for the bug.