[k3b] Review Request 114053: Replace Spinbox in LAME Encoder plugin settings with Slider for consistency.

[Jeffery MacEachern]

> On Nov. 23, 2013, 7:26 a.m., Christoph Feck wrote:
> > plugins/encoder/lame/k3blameencoderconfigwidget.cpp, line 60
> > <http://git.reviewboard.kde.org/r/114053/diff/1/?file=219346#file219346line60>
> >
> >     If you check the API docs for KIntNumInput, you will see what the _actual_ bug was (see my hint at the bug report).
> >     
> >     While removing the spin box is certainly doable, it also removes the display of the current value.

Ah, I misunderstood. I see what you were referring to now.


- Jeffery


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114053/#review44266
-----------------------------------------------------------


On Nov. 23, 2013, 5:01 p.m., Jeffery MacEachern wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114053/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 5:01 p.m.)
> 
> 
> Review request for K3b and Christoph Feck.
> 
> 
> Bugs: 327932
>     http://bugs.kde.org/show_bug.cgi?id=327932
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> Replaces the spinbox in the Advanced tab of the LAME Encoder plugin settings with a slider for consistency. What's This and Tooltip text were copied verbatim, though the appropriateness of them could be questioned, since they refer to numeric values not shown by the slider.
> 
> 
> Diffs
> -----
> 
>   plugins/encoder/lame/k3blameencoderconfigwidget.cpp 5e6c3f7 
> 
> Diff: http://git.reviewboard.kde.org/r/114053/diff/
> 
> 
> Testing
> -------
> 
> Built, installed, ran. UI displayed and functioned as expected, and it's essentially a drop-in replacement.
> 
> 
> Thanks,
> 
> Jeffery MacEachern
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20131124/ebc31097/attachment-0001.html>