[k3b] Review Request 114053: Replace Spinbox in LAME Encoder plugin settings with Slider for consistency.

Jeffery MacEachern j.maceachern at gmail.com
Sat Nov 23 13:47:43 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114053/
-----------------------------------------------------------

Review request for K3b and Christoph Feck.


Bugs: 327932
    http://bugs.kde.org/show_bug.cgi?id=327932


Repository: k3b


Description
-------

Replaces the spinbox in the Advanced tab of the LAME Encoder plugin settings with a slider for consistency. What's This and Tooltip text were copied verbatim, though the appropriateness of them could be questioned, since they refer to numeric values not shown by the slider.


Diffs
-----

  plugins/encoder/lame/base_k3blameencodersettingswidget.ui 351b747 
  plugins/encoder/lame/k3blameencoderconfigwidget.cpp 5e6c3f7 

Diff: http://git.reviewboard.kde.org/r/114053/diff/


Testing
-------

Built, installed, ran. UI displayed and functioned as expected, and it's essentially a drop-in replacement.


Thanks,

Jeffery MacEachern

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20131123/a79d5827/attachment.html>


More information about the k3b mailing list