[k3b] Review Request 106179: krazy: single-char optimization.

Francesco Cecconi francesco.cecconi at gmail.com
Sat Mar 23 10:55:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106179/
-----------------------------------------------------------

(Updated March 23, 2013, 10:55 a.m.)


Status
------

This change has been marked as submitted.


Review request for K3b.


Description
-------

Use QChar for single character instead of QString.


Diffs
-----

  libk3b/tools/k3bcddb.cpp 4a64d95 
  libk3b/tools/k3bdevicehandler.cpp 1ddc473 
  libk3b/tools/k3bintvalidator.cpp 9e399c8 
  libk3b/tools/k3biso9660.cpp 29db4cc 
  libk3b/projects/movixcd/k3bmovixdocpreparer.cpp 7d68121 
  libk3b/projects/videocd/k3bvcddoc.cpp f0485d6 
  libk3b/projects/videocd/k3bvcdjob.cpp 348b399 
  libk3b/projects/mixedcd/k3bmixedjob.cpp b16daf2 
  libk3b/projects/datacd/k3bmsinfofetcher.cpp 89fad60 
  libk3b/projects/k3bcdrdaowriter.cpp 3d2b26b 
  libk3b/projects/k3bcuefileparser.cpp f255233 
  libk3b/projects/k3bgrowisofswriter.cpp b036bf6 
  libk3b/projects/datacd/k3bisoimager.cpp 874a0f0 
  libk3b/projects/datacd/k3bdatamultisessionparameterjob.cpp 32e1700 
  libk3b/projects/datacd/k3bdiritem.cpp 9c27b73 
  libk3b/projects/datacd/k3bdataitem.cpp 0c49971 
  libk3b/projects/audiocd/k3baudiojobtempdata.cpp 904580c 
  libk3b/projects/datacd/k3bdatadoc.cpp f572247 
  libk3b/projects/audiocd/k3baudiofile.cpp 0d702a6 
  libk3b/projects/audiocd/k3baudiojob.cpp f6f9f7f 
  libk3b/jobs/k3bmetawriter.cpp 6a90b9b 
  libk3b/projects/audiocd/k3baudiocdtrackreader.cpp b2a525b 
  libk3b/jobs/k3bdvdformattingjob.cpp 4bb05a7 
  libk3b/jobs/k3biso9660imagewritingjob.cpp 821a4c3 
  libk3b/jobs/k3bdvdcopyjob.cpp a9877f8 
  libk3b/jobs/k3bbinimagewritingjob.cpp df5a2d5 
  libk3b/jobs/k3bcdcopyjob.cpp 87c7849 
  libk3b/jobs/k3bclonejob.cpp 6c1628b 
  kioslaves/videodvd/videodvd.cpp 22ea024 
  libk3b/core/k3bdefaultexternalprograms.cpp 25b84c4 
  libk3b/core/k3bexternalbinmanager.cpp 62238b4 
  libk3b/core/k3bglobals.cpp dc54daf 
  libk3b/core/k3bversion.cpp 6223265 
  libk3b/jobs/k3baudiocuefilewritingjob.cpp 929aeae 
  libk3b/tools/k3bprocess.cpp fa6dc90 
  libk3bdevice/k3bdevicemanager.cpp fad37f8 
  plugins/encoder/ogg/k3boggvorbisencoderconfigwidget.cpp a1074a1 
  src/k3b.cpp f7affb4 
  src/k3bappdevicemanager.cpp ca13760 
  src/k3bdebuggingoutputcache.cpp 42da898 
  src/k3bdebuggingoutputfile.cpp 2a60c5c 
  src/k3bdiskinfoview.cpp 0ea174a 
  src/k3bfileview.cpp 90b91e0 
  src/k3bstatusbarmanager.cpp 20a9461 
  src/k3btempdirselectionwidget.cpp c7d3da6 
  src/k3bthememanager.cpp 8923939 
  src/k3bwriterselectionwidget.cpp d7d2ecf 
  src/misc/k3bimagewritingdialog.cpp 9feeb1b 
  src/option/k3badvancedoptiontab.cpp fc8a898 
  src/option/k3bdevicewidget.cpp c5919ba 
  src/option/k3bexternalbinpermissionmodel.cpp 803e162 
  src/projects/k3bdatapropertiesdialog.cpp cfe4cb9 
  src/projects/k3bdataurladdingdialog.cpp 62e9ae0 
  src/projects/k3bfillstatusdisplay.cpp 881f647 
  src/projects/k3bvcdburndialog.cpp f9a7d50 
  src/projects/kostore/KoStore.cpp 405f1cf 
  src/rip/k3baudiocdview.cpp 77da736 
  src/rip/k3baudioprojectconvertingdialog.cpp de72438 
  src/rip/k3baudioripjob.cpp 3765eb2 
  src/rip/k3baudiorippingdialog.cpp 881461c 
  src/rip/k3bvideocdview.cpp 27a47bf 
  src/rip/videodvd/k3bvideodvdrippingview.cpp d4598c9 

Diff: http://git.reviewboard.kde.org/r/106179/diff/


Testing
-------


Thanks,

Francesco Cecconi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20130323/2a23e957/attachment.html>


More information about the k3b mailing list