[k3b] Review Request: CMake checks for FFmpeg API changes

Alex Merry kde at randomguy3.me.uk
Fri Aug 24 02:15:48 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106153/
-----------------------------------------------------------

Review request for K3b.


Description
-------

CMake checks for FFmpeg API changes

FFmpeg breaks bc every so often.  The safest way to deal with this is
with CMake checks for the new API.  This implements such checks for most
of the recent changes and deprecations (one function that is deprecated
in ffmpeg 0.11 remains).

This simplifies the code considerably, at the expense of complicating CMakeLists.txt a little.

There is one remaining deprecated function: avcode_decode_audio3, which is replaced by avcode_decode_audio4.  However, this produces output in quite a different format, so the change would be more invasive.

The FFMPEG_CODEC macro changes are a separate commit, and so easy to drop if necessary.


Diffs
-----

  config-k3b.h.cmake 50c4a999fa58bbcdf4624ad9c04c05ef04a74b9d 
  plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp 024c18ca36adc96edb5824b8efa9853634bf2528 
  CMakeLists.txt e42568df47b9501cc3da69501097b7c298490231 

Diff: http://git.reviewboard.kde.org/r/106153/diff/


Testing
-------

Builds with FFmpeg 0.11.  Not checked with earlier versions.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20120824/b9f39110/attachment.html>


More information about the k3b mailing list