[k3b] Review Request: K3b::IsOverburnAllowed: Increase tolerance from 10% to 25%

[Kevin Kofler]

> On Sept. 17, 2011, 8:43 p.m., Kevin Kofler wrote:
> > Hmmm, wait a minute, now that I proofread my code change, I'm left to wonder whether the code is making sense at all:
> > > (projectSize + usedCapacity) <= ( capacity.lba() - usedCapacity.lba() + capacity.lba() * 10 / 100 ) ); // 10% tolerance in overburn mode
> > I changed it to:
> > > (projectSize + usedCapacity) <= ( capacity.lba() - usedCapacity.lba() + capacity.lba() / 4 ) ); // 25% tolerance in overburn mode
> > (without touching the logic), but why are we both adding usedCapacity on the left and subtracting it on the right?!

This formula is clearly incorrect, I fixed it (fix pushed to master and 2.0):
http://bugs.kde.org/show_bug.cgi?id=276002#c8


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102648/#review6601
-----------------------------------------------------------


On Sept. 17, 2011, 4:30 p.m., Kevin Kofler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102648/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2011, 4:30 p.m.)
> 
> 
> Review request for K3b.
> 
> 
> Summary
> -------
> 
> 10% are not enough to allow using CD-R90 and CD-R99 media to full capacity.
> The new 25% tolerance allows using those media while still catching the common
> case of DVD ISO vs. CD media.
> 
> 
> This addresses bug 276002.
>     http://bugs.kde.org/show_bug.cgi?id=276002
> 
> 
> Diffs
> -----
> 
>   libk3b/core/k3bglobals.cpp 1a19f3b 
> 
> Diff: http://git.reviewboard.kde.org/r/102648/diff
> 
> 
> Testing
> -------
> 
> None. (The change is trivial.)
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20110917/c8085b00/attachment.html>