[k3b] Review Request: improved rendering of the inner color of themed headers
Hugo Pereira Da Costa
hugo at oxygen-icons.org
Fri May 13 07:30:14 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101350/
-----------------------------------------------------------
Review request for K3b.
Summary
-------
This patch fixes margins inside themed headers in order to improve the rendering of their inside colored part. See screenshot.
Note: right now, with oxygen from trunk, the rendering of the dialog attached is exactly identical.
This is because a (similar) patch has been added inside oxygen. Now, since its somewhat of a hack, (depending notably on the name of the non-public class for which the layout is to be altered), I'd rather get rid of it and have *this* patch pushed instead.
Besides, this patch also improves the rendering for other widget styles (though not as well as with oxygen).
Diffs
-----
src/k3bthemedheader.cpp f5eec73
Diff: http://git.reviewboard.kde.org/r/101350/diff
Testing
-------
tested with oxygen, plastique and skulpture.
Screenshots
-----------
K3B themed header
http://git.reviewboard.kde.org/r/101350/s/167/
Thanks,
Hugo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20110513/a259a03b/attachment.html>
More information about the k3b
mailing list