[k3b] Re: Review Request: improved rendering of the inner color of themed headers

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101350/#review3903
-----------------------------------------------------------


This review has been submitted with commit a40b149d860f60d28852f8de4bbe1b85b2c84fc5 by Hugo Pereira Da Costa to branch master.

- Commit


On May 13, 2011, 7:30 a.m., Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101350/
> -----------------------------------------------------------
> 
> (Updated May 13, 2011, 7:30 a.m.)
> 
> 
> Review request for K3b.
> 
> 
> Summary
> -------
> 
> This patch fixes margins inside themed headers in order to improve the rendering of their inside colored part. See screenshot.
> 
> Note: right now, with oxygen from trunk, the rendering of the dialog attached is exactly identical.
> This is because a (similar) patch has been added inside oxygen. Now, since its somewhat of a hack, (depending notably on the name of the non-public class for which the layout is to be altered), I'd rather get rid of it and have *this* patch pushed instead.
> 
> Besides, this patch also improves the rendering for other widget styles (though not as well as with oxygen).
> 
> 
> Diffs
> -----
> 
>   src/k3bthemedheader.cpp f5eec73 
> 
> Diff: http://git.reviewboard.kde.org/r/101350/diff
> 
> 
> Testing
> -------
> 
> tested with oxygen, plastique and skulpture.
> 
> 
> Screenshots
> -----------
> 
> K3B themed header
>   http://git.reviewboard.kde.org/r/101350/s/167/
> 
> 
> Thanks,
> 
> Hugo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/k3b/attachments/20110615/bcaf7a56/attachment.html>