[gwenview] /: Add FITS format support

Christoph Feck cfeck at kde.org
Mon Sep 25 21:34:18 UTC 2017


On 25.09.2017 23:15, Csaba Kertesz wrote:
> Git commit b49569c97a75598d93e4d0ee2efb61db075fbaa3 by Csaba Kertesz.
> Committed on 25/09/2017 at 21:08.
> Pushed by ckertesz into branch 'master'.
>
> Add FITS format support
>
> M  +3    -0    CMakeLists.txt
> M  +11   -0    app/CMakeLists.txt
> M  +6    -0    app/main.cpp
> A  +72   -0    cmake/FindCFitsio.cmake
> M  +6    -0    lib/CMakeLists.txt
> A  +2485 -0    lib/imageformats/fitsformat/bayer.c     [License: LGPL (v2.1+) (wrong address)]  *
> A  +275  -0    lib/imageformats/fitsformat/bayer.h     [License: LGPL (v2.1+) (wrong address)]  *
> A  +697  -0    lib/imageformats/fitsformat/fitsdata.cpp     [License: GPL (v2+)]
> A  +139  -0    lib/imageformats/fitsformat/fitsdata.h     [License: GPL (v2+)]
> A  +82   -0    lib/imageformats/fitshandler.cpp     [License: GPL]
> A  +42   -0    lib/imageformats/fitshandler.h     [License: GPL]
> A  +68   -0    lib/imageformats/fitsplugin.cpp     [License: GPL]
> A  +47   -0    lib/imageformats/fitsplugin.h     [License: GPL]
> A  +4    -0    lib/imageformats/fitsplugin.json
> M  +63   -1    lib/imagemetainfomodel.cpp
>
> The files marked with a * at the end have a non valid license. Please read: http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.
>
>
> https://commits.kde.org/gwenview/b49569c97a75598d93e4d0ee2efb61db075fbaa3

Hi,

thanks for your contribution. Is this the result of a GSoC project? I 
would have expected a code review request.

Could you please add a reference (URL/mailing list discussion) where 
this was evaluated?

Additionally, I am not sure this should have been committed to Gwenview. 
We have a kimageformat framework where we collect image I/O plugins for 
formats that Qt does not support.

See https://cgit.kde.org/kimageformats.git/

Christoph Feck
KDE Quality Team



More information about the Gwenview-devel mailing list