Review Request 128868: Fix regression (fails to build from source) when building against Qt <= 5.7.

[Johan Ouwerkerk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128868/
-----------------------------------------------------------

(Updated Jan. 20, 2017, 11:31 p.m.)


Status
------

This change has been discarded.


Review request for Gwenview, Frederik Gladhorn and Ivan Čukić.


Repository: gwenview


Description
-------

The qAsConst() macro is not available in Qt prior to 5.7, so manually use a const-ref to the container to get the desired behaviour.
(The goal is to avoid detaching of the container).

Note that if the use of if-defs is considered too ugly, there are the following alternatives:
 - Revert to using Q_FOREACH() as is done right below the ranged-for loop in the same function anyway
 - Use the manual const-ref version and drop the qAsConst() variant entirely.
 - If the container is only ever accessed from the same thread, ignore the issue and don't bother with the const-ref (because then there shouldn't be any detaching anyway in this code).
 - Bump the required Qt version to >= 5.7


Diffs
-----

  lib/mimetypeutils.cpp 580f9426daa64a7ecda6fccd28fc1ec2d6d51eca 

Diff: https://git.reviewboard.kde.org/r/128868/diff/


Testing
-------

Built with kdesrc-build against Qt 5.6.x on Debian (Unstable/Sid).


Thanks,

Johan Ouwerkerk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20170120/c4e11d83/attachment.html>