Review Request 129922: Adding Fit to width

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129922/#review102668
-----------------------------------------------------------



Sorry you did not get an answer earlier, looks like great work. Will need to dig a bit more into it.


lib/documentview/documentview.cpp (line 508)
<https://git.reviewboard.kde.org/r/129922/#comment68348>

    Why did you disable this code? If there is a good reason, it should be removed, not commented out.



lib/documentview/documentview.cpp (line 518)
<https://git.reviewboard.kde.org/r/129922/#comment68349>

    Same here.


- Aurélien Gâteau


On Feb. 5, 2017, 1:15 a.m., Eldin Gagulić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129922/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2017, 1:15 a.m.)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Hi,
> 
> I found it useful to have Fit to Width option for things I use gwenview for, so I added it.
> It's allmost completely copied code from Fit option, with few exceptions. If you think it will be useful add it.
> 
> P.S. I never contribute for KDE before.
> 
> 
> Diffs
> -----
> 
>   lib/documentview/abstractdocumentviewadapter.h 4fc9b135 
>   lib/documentview/abstractimageview.h f7dd32ea 
>   lib/documentview/abstractimageview.cpp f01b341d 
>   lib/documentview/documentview.h b9f436e0 
>   lib/documentview/documentview.cpp 28415d3b 
>   lib/documentview/documentviewcontroller.h 26e8f9c6 
>   lib/documentview/documentviewcontroller.cpp 40e29cbc 
>   lib/documentview/documentviewsynchronizer.h 0a7c9da2 
>   lib/documentview/documentviewsynchronizer.cpp 89b0b61f 
>   lib/documentview/rasterimageview.cpp 5c4f5514 
>   lib/documentview/rasterimageviewadapter.h b6221271 
>   lib/documentview/rasterimageviewadapter.cpp af9bbd46 
>   lib/documentview/svgviewadapter.h eae9a03a 
>   lib/documentview/svgviewadapter.cpp 5069b777 
>   lib/zoomwidget.h d5de70b9 
>   lib/zoomwidget.cpp cae63b6e 
> 
> Diff: https://git.reviewboard.kde.org/r/129922/diff/
> 
> 
> Testing
> -------
> 
> Compiles, runs. Tested with couple of raster and svg images.
> 
> 
> Thanks,
> 
> Eldin Gagulić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20170226/cdb2f11e/attachment.html>