Review Request 129004: Offer to install kipi if it is not installed

[Aleix Pol Gonzalez]

> On Sept. 23, 2016, 7:07 p.m., Aleix Pol Gonzalez wrote:
> > I'd say it would be much simpler to do `QDesktopServices::openUrl("appstream:/photolayoutseditor.desktop")`, which will open Discover/GnomeSoftware/whatever.
> 
> Jonathan Riddell wrote:
>     This is what Harald suggested and I was thinking of doing an alternative with that to compare.
>     
>     But running xdg-open appstream:/photolayoutseditor.desktop  just opens Discover as if opened normally and installs nothing (same when using QDesktopServices::openUrl).
>     
>     Also I wonder if distros would prefer a runtime dep on discover to a compiletime dep on PK and appstream.
>     
>     Also I'm not convinced it's simpler from a programming view, Packagekit allows for some API to check it's succeeded or not, using plasma-discover would need to check return codes and/or file watches on plugin directories which is just as difficult to program and probably less reliable.
> 
> Jonathan Riddell wrote:
>     <Sho_> it opened discover for me
>     <Sho_> discover didn't do much with it and looks kinda broken
>     says Eike on Fedora, so not just me
>     
>     also whenever I asked about it a year ago in the office you said to just use packagekit :)

`QDesktopServices::openUrl("appstream://photolayoutseditor.desktop")` was missing a slash.

Can be, I'm growing a hard dislike towards optional build dependencies, but maybe that's just me.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129004/#review99488
-----------------------------------------------------------


On Sept. 26, 2016, 6:49 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129004/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 6:49 p.m.)
> 
> 
> Review request for Gwenview and Aleix Pol Gonzalez.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Use Appstream and Packagekit to offer to install Kipi plugins if they are not already installed
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 82b219a 
>   app/CMakeLists.txt ed77d7c 
>   app/kipiinterface.h 1c06cd4 
>   app/kipiinterface.cpp 04dccb3 
> 
> Diff: https://git.reviewboard.kde.org/r/129004/diff/
> 
> 
> Testing
> -------
> 
> compile without appstream/packagekit, works same as before
> compile with them it adds a menu entry to install it.  This pops up a progressdialog while packagekit installs it.  on install the menu gets reloaded with new plugins
> (note this doesn't work on neon currently because libkipi-data installs the dummy test plugins so it considers kipi-plugins to be installed, delete those before trying)
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160926/9f3ee8aa/attachment-0001.html>