Review Request 128868: Fix regression (fails to build from source) when building against Qt <= 5.7.

Johan Ouwerkerk jm.ouwerkerk at gmail.com
Fri Sep 9 05:56:00 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128868/
-----------------------------------------------------------

(Updated Sept. 9, 2016, 5:56 a.m.)


Review request for Gwenview.


Repository: gwenview


Description
-------

The qAsConst() macro is not available in Qt prior to 5.7, so manually use a const-ref to the container to get the desired behaviour.
(The goal is to avoid detaching of the container).


Diffs
-----

  lib/mimetypeutils.cpp 580f9426daa64a7ecda6fccd28fc1ec2d6d51eca 

Diff: https://git.reviewboard.kde.org/r/128868/diff/


Testing (updated)
-------

Built with kdesrc-build against Qt 5.6.x on Debian (Unstable/Sid).


Thanks,

Johan Ouwerkerk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160909/7e0ca340/attachment.html>


More information about the Gwenview-devel mailing list