Review Request 129072: install kipi-plugins in gwenview using appstream:/ URLs

[Jonathan Riddell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129072/
-----------------------------------------------------------

(Updated Oct. 3, 2016, 3:28 p.m.)


Review request for Gwenview, Kipi-plugins, Aleix Pol Gonzalez, and Harald Sitter.


Changes
-------

Implement changes requested


Repository: gwenview


Description
-------

Alternative to patch https://git.reviewboard.kde.org/r/129004 for comparison, this uses an appstream:// URL to launch Plasma Discover (or whatever you have that handles those URLs) to install kipi-plugins.  A file watcher will update the menu when it spots the plugins have been installed.

As discussed on other review request, I prefer the built in approach as user experience.  Discover is quite a complex window that gets shown to the user and it may not be clear that the user needs to click install and wait then close Discover and check the menu again.  The simple modal dialog of the other patch seems easier to users.


Diffs (updated)
-----

  app/kipiinterface.h 1c06cd4 
  app/kipiinterface.cpp 04dccb3 

Diff: https://git.reviewboard.kde.org/r/129072/diff/


Testing
-------

built it, tried to use discover to install kipi (reverted to using apt as it doesn't work on Neon currently) and noted the menu gets filled


Thanks,

Jonathan Riddell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20161003/c5b98ebf/attachment-0001.html>