Review Request 129357: Bring back Gwenview importer

Aurélien Gâteau agateau at kde.org
Thu Nov 10 22:54:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129357/
-----------------------------------------------------------

(Updated Nov. 10, 2016, 11:54 p.m.)


Review request for Gwenview.


Changes
-------

Fixed all issues


Repository: gwenview


Description
-------

This patch ports Gwenview importer to KF5, so one can import photos again. There are no functional changes with the old KDE4 version, except for any regression I could have missed.


Diffs (updated)
-----

  CMakeLists.txt 645d4348a9500e406589e52cd508794d6856c8f2 
  importer/CMakeLists.txt 81e585c1e13ef22c84c92196754acb74a72862d5 
  importer/dialogpage.cpp f7a8fbc611b5473466895759fe978a31d70a53bb 
  importer/documentdirfinder.h 05b96236677426fd463ef6bfb8660a84fbf24522 
  importer/documentdirfinder.cpp 76e7d1b753edbc04212b6efb68de888ea8532c7c 
  importer/filenameformater.h f16409d303836e4ffaf223fceb315be30c8bdc9f 
  importer/filenameformater.cpp f9c33ec1fc996aad041482075e35af592aa5b6a4 
  importer/fileutils.h db10f56ead6fe9bcc9af384a6ef44aeee86bd29e 
  importer/fileutils.cpp 35a22e0b90c06a16f178923fb94f77109f760524 
  importer/gwenview_importer.desktop 2a9b68b9ba95ef532598be8d1831611b603a63fa 
  importer/importdialog.h 4abe82fce185f30f651b8d89c783a6444ed9e9b6 
  importer/importdialog.cpp 7c85f519d1cfb48858427db679a8eb387b0110c6 
  importer/importer.h 3efa282696133d239c0bee2f205e08cdbda3a9e2 
  importer/importer.cpp 0d849df9822fe850bef71be6e42becc8f3a50938 
  importer/importerconfigdialog.cpp 999a49f456ff56316c0c02d22282a50fc04c9788 
  importer/main.cpp edc7c8db2a2ce151afa18eeb0eb21c6d333a3bce 
  importer/progresspage.h 1a5e84b573f5093ef04188eb73d2220d17300e77 
  importer/serializedurlmap.h b50927e401d87e0a360199244c9609aa37ede507 
  importer/serializedurlmap.cpp 4127071d6bee4952cc91a11c2a42ee0da0105008 
  importer/thumbnailpage.h 95d500662bd36d9201b50394ce3c49d29d859828 
  importer/thumbnailpage.cpp 5032ca264ae7d20046b98767332346b3fdf84ef0 

Diff: https://git.reviewboard.kde.org/r/129357/diff/


Testing
-------

Imported photos and videos from SD card and from dirs on my hd. Works fine.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20161110/6fa31dcd/attachment-0001.html>


More information about the Gwenview-devel mailing list