Review Request 126678: Fix bug #356998 - previews are not updated after undo operations.

Aurélien Gâteau agateau at kde.org
Sun Jan 10 22:42:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126678/#review90860
-----------------------------------------------------------


Do you think this could be done without adding a new method, by making implementations of AbstractDocumentEditor::setImage and applyTransformation emit the modified() signal?

- Aurélien Gâteau


On jan. 8, 2016, 12:40 après-midi, Shlomi Fish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126678/
> -----------------------------------------------------------
> 
> (Updated jan. 8, 2016, 12:40 après-midi)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This fixes bug #356998 - previews are not updated after undo operations.
> 
> 
> Diffs
> -----
> 
>   lib/crop/cropimageoperation.cpp 7822d1e 
>   lib/document/document.h 550a6d2 
>   lib/document/document.cpp 0ed83cf 
>   lib/redeyereduction/redeyereductionimageoperation.cpp 9e5e930 
>   lib/resize/resizeimageoperation.cpp a31c64c 
> 
> Diff: https://git.reviewboard.kde.org/r/126678/diff/
> 
> 
> Testing
> -------
> 
> Ran gwenview with the sample images and tested that undo/etc. update the preview.
> 
> 
> Thanks,
> 
> Shlomi Fish
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160110/67cd5c67/attachment.html>


More information about the Gwenview-devel mailing list