Review Request 126627: Replace screensaver inhibition by direct dbus calls

[Thomas Lübking]

> On Jan. 4, 2016, 10:07 p.m., Albert Astals Cid wrote:
> > Don't we really have something other than this complex code for apps to use? It'd be sad to see people copy&pasting this with subtle mistakes all over :/
> 
> Martin Klapetek wrote:
>     There is a thing in solid that is unfinished (there's a big chunk
>     of code with "WITH_NEW_POWER_ASYNC_API" cmake switch) and apparently
>     no solid maintainer to actually finished it.
>     
>     On the other hand, this ain't no complex code, it's a simple dbus
>     call with storing the reply and another dbus call sending the stored
>     reply. It's a long boring code, but not complex.
> 
> Martin Gräßlin wrote:
>     we could use your code to turn it into a library ;-)
> 
> Thomas Lübking wrote:
>     Like adding a PowerManagement flag to KNotificationRestrictions as well as a new constructor
>     KNotificationRestrictions(QString reason, Services control=NonCriticalServices, QObject *parent=0)
>     
>     Seems a natural solution =)
> 
> Martin Klapetek wrote:
>     I actually wanted to get rid of KNotificationRestriction,
>     it's used only by Gwenview and somehow really don't belong
>     to KNotifications anyway, it's disabling PM after all.
>     
>     @Martin G - well there is half finished thing in solid, it
>     needs someone to step up to it and decide what to do with it.

=> KIdleTime?
The feature itself could be interesting for okular or some video players as well - esp. in tier1, yesno?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126627/#review90599
-----------------------------------------------------------


On Jan. 4, 2016, 8:25 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126627/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 8:25 p.m.)
> 
> 
> Review request for Gwenview and Kai Uwe Broulik.
> 
> 
> Bugs: 334525
>     http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This is a better approach to fix bug 334525 than
> https://git.reviewboard.kde.org/r/125910/ which forces
> a default reason (which is user visible).
> 
> With this new patch Gwenview will set a proper reason
> why is it inhibitting the screensaver ("Full Screen Presentation")
> and will use the DBus directly rather than the obsolete
> KNotificationRestrictions API.
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.cpp 7b30c4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126627/diff/
> 
> 
> Testing
> -------
> 
> PowerDevil correctly shows that Gwenview is inhibitting
> the PM because "Full Screen Presentation".
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20160105/eb023525/attachment-0001.html>