Review Request 129717: Use KStandardAction::DeleteFile instead of manually created action

Elvis Angelaccio elvis.angelaccio at kde.org
Thu Dec 29 11:14:35 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129717/#review101646
-----------------------------------------------------------


Ship it!





CMakeLists.txt (line 57)
<https://git.reviewboard.kde.org/r/129717/#comment68082>

    Maybe move KIO together with the other frameworks? (since 5.25 > 5.4)


- Elvis Angelaccio


On Dec. 28, 2016, 10:40 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129717/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2016, 10:40 p.m.)
> 
> 
> Review request for Gwenview and Elvis Angelaccio.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Less code and along with https://git.reviewboard.kde.org/r/129299/ makes the ambiguous Shift+Delete go away
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a7f95be 
>   app/fileopscontextmanageritem.cpp a96722d 
>   app/thumbnailviewhelper.cpp 0fa467d 
> 
> Diff: https://git.reviewboard.kde.org/r/129717/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20161229/161cba91/attachment.html>


More information about the Gwenview-devel mailing list