Review Request 124416: Do not scale up images smaller than the thumbnail size

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124416/#review88050
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 14, 2015, 7:35 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124416/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2015, 7:35 a.m.)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> When generating thumbnails Gwenview asks the QImageReader to scale at load time if possible. Seems like the PNG reader gains support for this recently, resulting in Gwenview asking the PNG reader to scale images at load, including small images like icons, which gets scaled up to fit the thumbnail square. This is not good since it produces blurry thumbnails.
> 
> This patch checks if the image is larger than the thumbnail square before asking the QImageReader to scale.
> 
> 
> Diffs
> -----
> 
>   lib/thumbnailprovider/thumbnailgenerator.cpp 54875f5df89530edf3aacbd6c30cf893ce0eb405 
> 
> Diff: https://git.reviewboard.kde.org/r/124416/diff/
> 
> 
> Testing
> -------
> 
> Tested with small and large images.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20151105/0d70f73a/attachment.html>