Review Request 122873: Fix for wrong rotation of RAW images

[Martin Kyral]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122873/
-----------------------------------------------------------

(Updated March 31, 2015, 2:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for Gwenview.


Changes
-------

Submitted with commit f383a05dd25ce924094518962a4d82cbc914ee32 by Aurélien Gâteau on behalf of Martin Kyral to branch master.


Repository: gwenview


Description
-------

Displaying of RAW images in gwenview was broken by https://bugreports.qt.io/browse/QTBUG-37946. I am fixing (or rather workarounding it) by blocking EXIF rotation iff the loaded image is RAW.


Diffs
-----

  lib/document/loadingdocumentimpl.cpp cc8bea9 
  lib/thumbnailprovider/thumbnailgenerator.h 4571832 
  lib/thumbnailprovider/thumbnailgenerator.cpp 54875f5 

Diff: https://git.reviewboard.kde.org/r/122873/diff/


Testing
-------

Tested with various RAW files, used previously to test the RAW loading support itself & with some jpeg files (including https://github.com/recurser/exif-orientation-examples.git).

Seems OK.

Nevertheless, the fix is not complete as jpeg files extracted from the RAWs using 'dcraw -e' are still mis-rotated.


Thanks,

Martin Kyral

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150331/75bdd653/attachment.html>