Review Request 122873: Fix for wrong rotation of RAW images

[David Edmundson]

> On March 13, 2015, 12:35 p.m., David Edmundson wrote:
> > In that bug report that you linked to there's a commit fixing it which is in 5.4 which is out.
> > 
> > 
> > It also says:
> > >if an application is handling the rotation itself right now the image will be rotated twice.
> > 
> > 
> > This seems like it would be a bad idea to merge this then?
> 
> Martin Kyral wrote:
>     Yes and that fix actually broke RAW preview in gwenview.
>     
>     This patch does nothing more, than disabling the additional rotation for RAW previews (which is the broken case) while for all other formats there's no change at all.

Thanks. Seems sensible then. A comment in the code explaining why we have this logic be useful for future devs.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122873/#review77412
-----------------------------------------------------------


On March 9, 2015, 4:25 p.m., Martin Kyral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122873/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 4:25 p.m.)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Displaying of RAW images in gwenview was broken by https://bugreports.qt.io/browse/QTBUG-37946. I am fixing (or rather workarounding it) by blocking EXIF rotation iff the loaded image is RAW.
> 
> 
> Diffs
> -----
> 
>   lib/document/loadingdocumentimpl.cpp cc8bea9 
>   lib/thumbnailprovider/thumbnailgenerator.h 4571832 
>   lib/thumbnailprovider/thumbnailgenerator.cpp 54875f5 
> 
> Diff: https://git.reviewboard.kde.org/r/122873/diff/
> 
> 
> Testing
> -------
> 
> Tested with various RAW files, used previously to test the RAW loading support itself & with some jpeg files (including https://github.com/recurser/exif-orientation-examples.git).
> 
> Seems OK.
> 
> Nevertheless, the fix is not complete as jpeg files extracted from the RAWs using 'dcraw -e' are still mis-rotated.
> 
> 
> Thanks,
> 
> Martin Kyral
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150313/cf18f878/attachment-0001.html>