Review Request 123928: Apply display color profile to all images

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123928/#review81077
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Čer. 2, 2015, 4:51 odp., Jan Kundrát wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123928/
> -----------------------------------------------------------
> 
> (Updated Čer. 2, 2015, 4:51 odp.)
> 
> 
> Review request for Gwenview, Albert Astals Cid, Aurélien Gâteau, and Lukáš Tinkl.
> 
> 
> Bugs: 322149
>     http://bugs.kde.org/show_bug.cgi?id=322149
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> ...including those which do not have any embedded profile. Just treat
> them as sRGB, which is probably a reasonable choice. This makes a huge
> difference on wide-gamut displays.
> 
> LittleCMS doesn't support RGBA_Premultiplied because premultipled alpha
> doesn't "make a lot of sense with a color management system since color
> perception varies with intensity and the colorspace may not be linear
> across the color channels" (see [1] for why, and for an experimental
> patch which apparently didn't move anywhere and wasn't merged).
> 
> [1] http://sourceforge.net/p/lcms/mailman/message/30246542/
> 
> REVIEW: 123928
> BUG: 322149
> 
> 
> Diffs
> -----
> 
>   lib/cms/cmsprofile.h 014654ccf8592d0cfd6fae3e5186679c47a2e207 
>   lib/cms/cmsprofile.cpp 2e67e04b0532d37f3697458ffd87268474819a9a 
>   lib/documentview/rasterimageview.cpp 793e1aa86e46e77ef7a551b81af162029fadd60d 
>   lib/imagescaler.cpp a3597dbe47e454a73548e545d7edcfee64912904 
> 
> Diff: https://git.reviewboard.kde.org/r/123928/diff/
> 
> 
> Testing
> -------
> 
> On my DELL U3014, this makes gwenview usable once again. You do not want to see the pink tones here without this patch.
> 
> 
> Thanks,
> 
> Jan Kundrát
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150602/24a899ec/attachment.html>