Review Request 122983: [gwenview] Make tests optional

[Andreas Sturmlechner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122983/
-----------------------------------------------------------

(Updated July 30, 2015, 11:49 a.m.)


Status
------

This change has been discarded.


Review request for Gwenview.


Repository: gwenview


Description
-------

There was already a check performed in tests/auto to conditionally build them if Qt5Test_FOUND - so I moved that up one directory to expand it to tests/manual as well. find_package(Qt5Test) is already done in root CMakeLists.txt (and made optional as seen in kwin).


Diffs
-----

  CMakeLists.txt 2d2ab8d5594421cf4539db3e30425b1b11ef14be 
  tests/CMakeLists.txt a8a2913ca0fce5f58952373527d838a89f64cdfb 
  tests/auto/CMakeLists.txt 9757a582b9309e30f0c1edc286a541de853fed64 

Diff: https://git.reviewboard.kde.org/r/122983/diff/


Testing
-------

Built with and without tests. I am currently not able to get a success everywhere, but the patch doesn't change anything about it.

Also, something to be done about the following? `The dependency target "buildtests" of target "check" does not exist.`


Thanks,

Andreas Sturmlechner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150730/b4e2fb15/attachment.html>