Review Request 103692: replace mkdtemp for more portabilitiy
Lukáš Tinkl
lukas at kde.org
Tue Jan 6 13:38:00 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/103692/#review73261
-----------------------------------------------------------
I'd prefer the code be ported to QTemporaryDir instead, now that we're in the frameworks branch :)
- Lukáš Tinkl
On Led. 6, 2015, 9:06 dop., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/103692/
> -----------------------------------------------------------
>
> (Updated Led. 6, 2015, 9:06 dop.)
>
>
> Review request for Gwenview, David Faure and Lukáš Tinkl.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> since mkdtemp is not portable, I want to replace the code in question with the usage of KTempDir.
>
>
> Diffs
> -----
>
> importer/fileutils.cpp 2aa18b4
>
> Diff: https://git.reviewboard.kde.org/r/103692/diff/
>
>
> Testing
> -------
>
> it builds well. Since I have no idea how that code is used, I hope you can give me some hints?
>
>
> Thanks,
>
> Patrick Spendrin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gwenview-devel/attachments/20150106/8ac4198b/attachment.html>
More information about the Gwenview-devel
mailing list